Support for missing HTTP status codes #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,7 +87,7 @@ struct basic_response<tags::http_server> { | |||
| space_unavailable = 507, | |||
| network_authentication_required = 511 | |||
| } status; | |||
|
|
|||
There was a problem hiding this comment.
Please remove extra whitespace.
|
LGTM -- please address just the two nits, and I'll merge with no issues. If you can also run clang-format on the file, that would be nice, but not required. |
|
Ok, thanks! Removed the whitespace but the clang tools I don't have and won't start installing just for this if you don't mind. |
|
Definitely don't mind @lyytinen -- thanks again for doing this! Definitely appreciated. Now I'll just wait for Travis to do its thing and I should be able to merge this soon as that's done. 😄 Cheers |
deanberris
added a commit
that referenced
this pull request
Sep 10, 2014
Support for missing HTTP status codes
|
Took a while, but this is merged now @lyytinen -- thanks again! |
leecoder
pushed a commit
to leecoder/cpp-netlib
that referenced
this pull request
Apr 14, 2015
…atus-codes Support for missing HTTP status codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for missing HTTP status codes as a fix for issue #442.
The implementation is not that pretty as it still has a lot of redundancy (although less than in the original version) but it fixes the issue.