Fix gitignore #363
Merged
Fix gitignore #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current gitignore state is inconsistent: files with mask `*.cmake` is ignored but there is a file FindICU.cmake.
|
BTW files: is internal cmake files. Looks like gitignore designed to be used with in-source builds. |
|
You're right @ruslo -- can you make the change to .gitignore to remove these too? |
sure |
|
LGTM -- sorry, it took a while for me to get to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current gitignore state is inconsistent: files with mask
*.cmakeis ignoredbut there is a file FindICU.cmake.