Added a client certificate support. #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM Well done @redboltz -- this looks very good! I'm merging this in. :) Thank you for doing this! |
deanberris
added a commit
that referenced
this pull request
Jan 20, 2014
Added a client certificate support.
ghost
assigned
leecoder
pushed a commit
to leecoder/cpp-netlib
that referenced
this pull request
Apr 14, 2015
…icate Added a client certificate support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added client::options to openssl_certificate_file() and openssl_private_key_file(). They correspond to Boost.Asio's use_certificate_file() and use_private_key_file().
Naming decisions:
Note:
I have an idea to rename the existing member function openssl_certificate() to some different name. But it would be a breaking change and I believe that I shouldn't include it in this pull request.
The reasons that I'd like to rename openssl_certificate() are as follows:
If you agree with my idea, I'm ready to make a pull request. For existing users, keeping openssl_certificate() as a deprecated alias of openssl_verify_file().