added ws2_32 and wsock32 target libraries to cmake files that is require... #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ired to build under mingw
ghost
assigned
|
Thanks @MeTheRealOne -- are you able to test this change in other OSes (like Linux)? |
|
The changed lines specifically effect Windows&GNU environment only with if clauses but still I can test it in Linux after 1st of January. |
|
I pulled the forked repo and it successfully built on 3.12.6-1-ARCH using clang++. |
|
LGTM Awesome, thanks @MeTheRealOne -- merging now. |
deanberris
added a commit
that referenced
this pull request
Jan 6, 2014
added ws2_32 and wsock32 target libraries to cmake files that is require...
leecoder
pushed a commit
to leecoder/cpp-netlib
that referenced
this pull request
Apr 14, 2015
added ws2_32 and wsock32 target libraries to cmake files that is require...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...d to build under mingw