Skip to content

First iteration of the HTTP client for cpp-netlib v1.0.0a #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 105 commits into from
Dec 18, 2013
Merged

First iteration of the HTTP client for cpp-netlib v1.0.0a #350

merged 105 commits into from
Dec 18, 2013

Conversation

glynos
Copy link
Member

@glynos glynos commented Dec 16, 2013

What is there to say? Too much for this description. Just:

  1. I not only updated the code, I updated some of the configuration too.
  2. The HTTP client is far from feature complete at this stage, but I am not too worried about that yet
    a. byte_source is not implemented, therefore no request body yet
    b. client_options and request_options need work
    c. No SSL for now
  3. The implementation diverges from the design doc: https://docs.google.com/document/d/1jUJxs99bcbxAFIWn4Slm8JIMMmrtKc3jwhBz6Da05Lk/edit#heading=h.2sedacots1jw we should discuss this
  4. I added a .travis.yml for CI: everything compiles, all tests pass for all build configurations
  5. We need to come up with a way of merging what we can from 0.11-devel into master
  6. Source documentation is incomplete
  7. Run make doc to generate the class documentation (make sure doxygen is installed)
  8. the best thing to do first is to look at the tests, and at the simple examples (under the contrib folder)

And many other things that we can discuss when you have time to look at this.

glynos added 30 commits August 26, 2013 18:32
@glynos
Cleaned up thread_pool so that I can read it more clearly.
faade8a
@glynos
Started HTTP client rewriting by removing some redundant files.
19a8b0f
@glynos
Removed a redundant header from the message framework.
2b2c2d3
@glynos
Removed basic_storage_* types that were not being used.
e1bbd36
@glynos
Removed some more redundant files.
e888689
@glynos
Removed some more files that were not being used.
f169c24
@glynos
Removed redundant tests.
297a773
@glynos
First commit of network::http::v2::client.
8bcce7a
@glynos
Updated first set of HTTP client tests.
fb7eecf
@glynos
Updated client_options tests.
6b51a82
@glynos
Moved some of the tests around; added class that will represent HTTP …
07e1e8e 
…URLs.
@glynos
Added a some extra options for the client and the request; removed so…
4eac522 
…me files I added.
@glynos
Updated client sources, adding some more tests.
71757f1
@glynos
Added some additional tests for the HTTP URL.
73b0831
@glynos
Added a message_base class.
70a99a9
@glynos
Added HTTP constants for client 1.0.x.
40e3b59
@glynos
Updated and added HTTP constants.
f23c827
@glynos
Updated constants and message headers.
72ea85e
@glynos
Updated build scripts so as not to build the old client and server; a…
06cd005 
…dded a basic test fixture for the client.
@glynos
Next iteration of improvements, still a long way from a working HTTP …
5ecb5c7 
…client.
@glynos
Added a client_errors file and invalid_scheme class.
41f4ec2
@glynos
Added tests and methods to the HTTP request.
b700bcc
@glynos
Added async_resolver.
6540a84
@glynos
Added logging again to project.
7f9f50e
@glynos
Added connection_timeout exception.
d653b4b
@glynos
Added resolver_error.
055e513
@glynos
Added resolver delegate.
06b8b94
@glynos
Added connection_delegate and test files (no test cases yet).
5b82479
@glynos
Removed message_base.hpp
88f6faf
@glynos
Updated errors and the HTTP request.
0610d08
glynos added 22 commits December 7, 2013 17:28
@glynos
Added an endpoint_cache class; refactored async_resolver.
416fe04
@glynos
Made async_resolver and ABC; added implementation in tcp_resolver.
58d5f94
@glynos
Test fails with an exception instead of a crash - progress of a kind...
44b9185
@glynos
Fixed crash in HTTP client, 'get' now only returns an empty response.
2012b58
@glynos
Continued to work on the HTTP client.
a8bad17
@glynos
Updated the client and response classes in order to make a successful…
619255a 
… HEAD request.
@glynos
Validated that the HEAD response returns the headers.
ce3bccf
@glynos
Lower case enum for HTTP status code for consistency.
6eb8e03
@glynos
Updated client errors and added code to allow the processing of a res…
b6c2bee 
…ponse body.
@glynos
Re-added and updated HTTP examples.
8f5ea83
@glynos
Added .clang-format for source code formatting.
5d8d744
@glynos
Allow the v0.x HTTP server to be built; Refactored HTTP v2 client req…
6441091 
…uest and response.
@glynos
Refactored client connections into a client_connection namespace.
d5b65ee
@glynos
Fixed bug in parsing the HTTP headers in the HTTP client.
23ef8d0
@glynos
Refactored internals of client.
6830eba
@glynos
Continued to refactor the HTTP client; made the method enum class low…
6ff897f 
…er case for consistency.
@glynos
Continued to refactor and document the HTTP client source and tests.
1238f44
@glynos
Continued refactoring, improved read_headers and simple_wget examples.
3e33f13
@glynos
Updated uri submodule.
a465cd8
@glynos
Added a flag to turn on/off the feature tests, which may access the n…
49310b1 
…etwork.
@glynos
Added .travis.yml
ebc7762
@glynos
Fixed some warnings in the HTTP client request and client_exception.
e639f47
@ghost ghost assigned deanberris Dec 16, 2013
deanberris
deanberris reviewed Dec 18, 2013
View reviewed changes
.clang-format
ExperimentalAutoDetectBinPacking: false
IndentCaseLabels: true
MaxEmptyLinesToKeep: 1
NamespaceIndentation: All
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please not indent namespaces?

@deanberris
Copy link
Member

So this change is big enough that I'm happy to merge it and iterate. Most of my comments are in the style of the code, but we can automate the fixing of that now. :)

LGTM

deanberris added a commit that referenced this pull request Dec 18, 2013
@deanberris
Merge pull request #350 from glynos/master
f272cb4 
First iteration of the HTTP client for cpp-netlib v1.0.0a
@deanberris deanberris merged commit f272cb4 into cpp-netlib:master Dec 18, 2013
@glynos
Copy link
Member Author

glynos commented Dec 18, 2013

Awesome, thanks Dean!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deanberris deanberris

Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@glynos @deanberris