Added all HTTP status codes #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added all the missing HTTP v1.1 status codes and corrected the naming to the standard of some of the existing ones.
| partial_content = 206, | ||
| multiple_choices = 300, | ||
| moved_permanently = 301, | ||
| moved_temporarily = 302, | ||
| found = 302, |
There was a problem hiding this comment.
I'm wary of making potentially breaking changes like these. Can you avoid renaming "moved_temporarily" here?
|
Thanks @patlecat -- if you can keep the old names and introduce new ones with the same value in the enum definition, that would be nice. |
I added the incorrectly named HTTP status code names back in but marked them as deprecated for the documentation. Now we have both names.
|
Better? :) |
|
Much better -- thanks @patlecat! Merging this now. LGTM |
leecoder
pushed a commit
to leecoder/cpp-netlib
that referenced
this pull request
Apr 14, 2015
Added all HTTP status codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all the missing HTTP v1.1 status codes and corrected the naming to
the standard of some of the existing ones.
-> 100 was named continue_http to avoid problems with the reserved word.