fixed read timeout in chucked content response for sync keep-alive client #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
| throw boost::system::system_error(error); | ||
| stopping_inner = true; | ||
| if (response_buffer.size() < (chunk_size+2)){ | ||
| std::size_t toRead = (chunk_size+2) - response_buffer.size(); |
There was a problem hiding this comment.
nit: I would prefer you call this variable bytes_to_read.
|
Generally, LGTM -- but if you have time to address that nit, I would appreciate it very much. :) Thanks @mepahoo ! |
|
Cool, thanks -- this LGTM. Sorry for the delay, I didn't know it was ready for another look. :) |
deanberris
added a commit
that referenced
this pull request
Nov 24, 2013
fixed read timeout in chucked content response for sync keep-alive client
leecoder
pushed a commit
to leecoder/cpp-netlib
that referenced
this pull request
Apr 14, 2015
fixed read timeout in chucked content response for sync keep-alive client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some testing, i noticed the keep-alive sync http client waited about 20 seconds before returning a trivial content (about 111 bytes). I tracked it down to this fix. The problem was that boost::asio::read is called, even if there are enough bytes in the current stream buffer. This causes read to wait until timeout (which on my windows platform was 20 secs, apparently). The fix is to not read if there are enough bytes in the current stream buffer. I am also counting 2 extra bytes for "\r\n" that comes after each chunk.