Skip to content

Declare the BASE64 alphabet as array of chars; not as a pointer #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2013

Conversation

prantlf
Copy link

@prantlf prantlf commented Sep 15, 2013

No description provided.

@deanberris
Copy link
Member

LGTM -- thanks @prantlf ! I'll look forward to the docs merged next. :)

deanberris added a commit that referenced this pull request Sep 16, 2013
Declare the BASE64 alphabet as array of chars; not as a pointer
@deanberris deanberris merged commit aef1e7d into cpp-netlib:0.10-devel Sep 16, 2013
@prantlf
Copy link
Author

prantlf commented Sep 17, 2013

Let's see. I'm going to have a look at the cpp-netlib documentation structure, but before "going wild" with the programmer's guide I wanted to try the two possibilities how to design the API - separate function templates or one class template. I tried to continue with the separate functions in the base64_util_function_templates branch and not being able to typedef the specialization is annoying me:

std::string result = base64::encode<base64::normal, char>("...");

std::back_insert_iterator<std::string> result_encoder(result);
base64::encode<base64::mime>("...", std::back_inserter(encoder), rest);
...
base64::encode_rest<base64::mime>(encoder, rest);

std::stringstream output;
output << base64::io::encode<base64::normal>("abc") <<
      base64::io::encode_rest<base64::normal, char>;

I'd like to try the static class approach and see what will annoy me there :-)

leecoder pushed a commit to leecoder/cpp-netlib that referenced this pull request Apr 14, 2015
Declare the BASE64 alphabet as array of chars; not as a pointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants