Initial version of base64 encoding #300
Conversation
…nchmarking tool and conclusion
… characters becomes private
| // from the input sequence to encode. | ||
| template <typename Value> | ||
| char encode_value(Value value) { | ||
| static char const * encoding = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/"; |
There was a problem hiding this comment.
I would think static char const encoding[] = "..."; would be better for many reasons here.
|
LGTM -- Thanks very much, this is very well-written! I'll merge this in as-is, and hopefully you can address that one nit in a follow-up PR. What's missing is just some documentation that's linked into the current documentation tree and we're golden! |
Initial version of base64 encoding
|
Thanks! I'm going to have a look how the the cpp-netlib RST documentation is organized. I like the idea of having the documentation outside the sources. I put comments to the code which should belong to the reference documentation. |
|
Happy to chat if you'd like to get more info -- find me on Google+ as 'mikhailberis@gmail.com' and we can hangout if you need more real-time or high-bandwidh feedback. :) |
Initial version of base64 encoding
Included:
Missing: