Skip to content

Improve build system #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2013
Merged

Improve build system #281

merged 3 commits into from
Aug 7, 2013

Conversation

niosHD
Copy link

@niosHD niosHD commented Aug 5, 2013

This PR works on the build system and fixes #273.

Comments are welcome!

regards,
niosHD

niosHD added 2 commits August 5, 2013 23:01
Using ordinary messages generates unnecessary noise when using ccmake.

(Should be done for the uri submodule as well.)
@ghost ghost assigned deanberris Aug 6, 2013
if(NOT CPP-NETLIB_BUILD_SINGLE_LIB)
add_library(cppnetlib-concurrency ${CPP-NETLIB_CONCURRENCY_SRCS})
endif()

# prepend current directory to make paths absolut
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/absolut/absolute/ ?

@deanberris
Copy link
Member

LGTM -- please just update the typo, and let me know so I can merge this. Thanks @niosHD!

@niosHD
Copy link
Author

niosHD commented Aug 6, 2013

@deanberris: Thanks! The typo is fixed.
Could you make the messages in the CMakelists.txt of the uri submodule STATUS messages as well? (Similar to my first commit in this branch.) Would save us the trouble of an additional PR on the other repo. :) Thanks in advance!

@deanberris
Copy link
Member

LGTM -- I think @glynos can make the changes to the URI in master if he's so inclined.

Thanks @niosHD!

deanberris added a commit that referenced this pull request Aug 7, 2013
@deanberris deanberris merged commit 8df1f1c into cpp-netlib:master Aug 7, 2013
@niosHD niosHD deleted the improve-build-system branch August 7, 2013 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake Error with CPP-NETLIB_BUILD_SINGLE_LIB=ON
2 participants