Fix issues #110 and #168. #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM For the master branch this looks OK. However I'm positive the bug was referring to something in the 0.9.4 branch -- in which case it might make sense to have another PR to the 0.9-devel branch (you can follow the same process you've followed to get this to master, although I would recommend you follow the steps in http://cpp-netlib.org/process.html for the proper approach). Thanks Chase! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempted fix at handling chunked transfer encoding in responses. This probably is not living in the correct place, but it appears to be working?
Attempts to fix issue #110 and issue #168.