Skip to content

Provide source port as part of the request #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2013

Conversation

3noch
Copy link

@3noch 3noch commented Jan 24, 2013

This might be a naive implementation. For example, I couldn't figure out how to mirror the source(request) behavior in the "hello world" example (e.g. how do I allow for source_port(request) instead of only request.source_port?).

Also, it appears that destination is not symmetric to source. I expected to see an IP in request::destination, but I saw the URL path instead. Thus, I did not add a destination_port member.

@deanberris
Copy link
Member

LGTM -- thanks Elliot!

deanberris added a commit that referenced this pull request Jan 25, 2013
Provide source port as part of the request
@deanberris deanberris merged commit d5a4f80 into cpp-netlib:0.9-devel Jan 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants