Skip to content

[2025-06-lwg-24] P3557R3 High-Quality Sender Diagnostics with Constexpr Exceptions #8035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

[2025-06-lwg-24] P3557R3 High-Quality Sender Diagnostics with Constexpr Exceptions #8035

merged 1 commit into from
Jul 16, 2025

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Jul 1, 2025 •
edited by jensmaurer
Loading

  • [exec.util.cmplsig] Subclause (now without siblings) promoted to \rSec1 (replacing [exec.util]) and renamed to [exec.cmplsig] "Completion signatures".
  • [exec.snd.expos]p24 Added missing \expos comments.
  • FIXED: [exec.snd.expos]p39 Unable to find paragraph to replace. Referenced paragraph starts: "Let Sndr be a (possibly const-qualified) specialization basic-sender" Inserted changes as new text after [exec.snd.expos]p41 instead.
  • FIXED: [exec.write.env] Unable to apply changes - section does not exist. Referenced paragraph starts: "write_env is a sender adaptor that accepts a sender and a queryable object"

Also fixes LWG4203.

Fixes #7961.
Fixes cplusplus/papers#2203

@jensmaurer
Copy link
Member

write_env is added here: #7973

@burblebee
Copy link
Contributor Author

#7973
Thanks Jens!

So rebasing on motions-2025-06-lwg-5 will give me [exec.write.env] from P3284R4 (so I can apply changes to [exec.write.env]), but change to [exec.snd.expos]p39 is still a problem, because the wording it changes assumes P3164R4 was applied.

@burblebee burblebee force-pushed the motions-2025-06-lwg-24 branch 2 times, most recently from 8fc26dd to a91ff84 Compare July 1, 2025 22:34
@burblebee burblebee marked this pull request as ready for review July 1, 2025 22:35
@burblebee
Copy link
Contributor Author

So rebasing on motions-2025-06-lwg-5 will give me [exec.write.env] from P3284R4 (so I can apply changes to [exec.write.env]), but change to [exec.snd.expos]p39 is still a problem, because the wording it changes assumes P3164R4 was applied.

  • Now rebased on motions-2025-06-lwg-5
  • Replaced [exec.snd.expos]p39 based on changes in P3164R4

Edits should all be in now.

@burblebee burblebee marked this pull request as draft July 2, 2025 02:15
@burblebee burblebee force-pushed the motions-2025-06-lwg-24 branch from a91ff84 to 961293f Compare July 2, 2025 05:35
@burblebee burblebee marked this pull request as ready for review July 2, 2025 05:47
ericniebler
ericniebler suggested changes Jul 3, 2025
View reviewed changes
source/exec.tex
otherwise, \exposid{none-such},
where \exposid{none-such} is an unspecified empty class type.
otherwise, \tcode{\placeholder{none-such}},
where \tcode{\placeholder{none-such}} is an unspecified empty class type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, why did these change from \exposid to \placeholder? i don't know what the difference it.

Copy link
Contributor Author

@burblebee burblebee Jul 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that \exposid is used for declarations marked \expos (or otherwise introduced as exposition entities). Here, we're introducing a local thingy to help describe/define something else, so \placeholder, math font, or even plain \tcode should be used. That said, I didn't realize I was "fixing" existing text when I was checking to make sure my additions were using the correct format, hopefully that was ok.

@burblebee burblebee requested a review from ericniebler July 8, 2025 22:25
@tkoeppe tkoeppe force-pushed the motions-2025-06-lwg-24 branch from 6b46a3f to 590f4ab Compare July 16, 2025 16:15
@burblebee @tkoeppe
P3557R3 High-Quality Sender Diagnostics with Constexpr Exceptions
8f3f68d 
* [exec.util.cmplsig] Subclause (now without siblings) promoted to \rSec1
  (replacing [exec.util]) and renamed to [exec.cmplsig] "Completion signatures".
* [exec.snd.expos] An unusual "Note:" element was turned into a regular note.
* [exec.snd.expos] Missing semicolon added in "Equivalent to:" code.

Also fixes LWG4203.
@tkoeppe tkoeppe force-pushed the motions-2025-06-lwg-24 branch from 590f4ab to 8f3f68d Compare July 16, 2025 16:23
@tkoeppe tkoeppe merged commit bb761a7 into main Jul 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

@ericniebler ericniebler ericniebler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@burblebee @jensmaurer @ericniebler @tkoeppe