Skip to content

P1317R2 Remove return type deduction in std::apply #7999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2025
Merged

P1317R2 Remove return type deduction in std::apply #7999

merged 2 commits into from
Jul 17, 2025

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Jun 23, 2025

Fixes #7972

@jwakely
Copy link
Member Author

jwakely commented Jun 23, 2025

I think we should bump __cpp_lib_apply for this.

Eisenwave
Eisenwave suggested changes Jun 23, 2025
View reviewed changes
@jwakely jwakely force-pushed the motions-2025-06-lwg-35 branch 3 times, most recently from 264537b to a1e2efa Compare June 23, 2025 18:17
@jwakely
Copy link
Member Author

jwakely commented Jun 23, 2025

I think we should bump __cpp_lib_apply for this.

I raised this on mattermost and got agreement. I was going to do it in a fixup commit, but I realised we might want to consider whether to add the macro to <type_traits>. It's currently only in <tuple> (and <version> of course).

@tkoeppe tkoeppe force-pushed the motions-2025-06-lwg-35 branch from a1e2efa to 768b82d Compare July 17, 2025 11:24
@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 17, 2025

I think we should bump __cpp_lib_apply for this.

I raised this on mattermost and got agreement. I was going to do it in a fixup commit, but I realised we might want to consider whether to add the macro to <type_traits>. It's currently only in <tuple> (and <version> of course).

@jwakely Is there an outcome?

@jwakely
Copy link
Member Author

jwakely commented Jul 17, 2025

I forgot all about it. I think it should be bumped and added to <type_traits>. We generally treat those macro values as editorial, but I'm not sure about which headers they're in. Do you want me to open an issue?

@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 17, 2025

If you're OK with it, I'd be happy to just editorially include this in this PR (feel free to add a commit?) -- what do you think?

@tkoeppe tkoeppe force-pushed the motions-2025-06-lwg-35 branch from 768b82d to 5de5984 Compare July 17, 2025 12:02
@jwakely @tkoeppe
P1317R2 Remove return type deduction in std::apply
568b5a1 
This commit adds "tuple-like<Tuple> is true and" to the definition of
apply_result. LWG noticed this was needed but we were unable to contact
the paper author to make the change in time for plenary.
@tkoeppe tkoeppe force-pushed the motions-2025-06-lwg-35 branch from 5de5984 to 568b5a1 Compare July 17, 2025 12:14
@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 17, 2025

Added it, PTAL

jwakely
jwakely commented Jul 17, 2025
View reviewed changes
Copy link
Member Author

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@tkoeppe tkoeppe merged commit e5a0678 into main Jul 17, 2025
4 checks passed
This was referenced Jul 17, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eisenwave Eisenwave Eisenwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2025-06 LWG Motion 35] P1317R2 Remove return type deduction in std::apply
3 participants
@jwakely @tkoeppe @Eisenwave