Skip to content

Clarify functions, member functions, and constructors #6946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

frederick-vs-ja
Copy link
Contributor

We shouldn't say "constructors and/or member functions", "functions name or member function name". or "function or constructor" etc., because

  • a constructor is a member function, and
  • a member function is a function, and
  • a constructor is a function.

I'm not very sure of the last point. But as a constexpr constructor is considered to be a constexpr function, I think it's consistent to say a constructor is a function.

@tkoeppe tkoeppe requested a review from jwakely June 17, 2025 16:56
@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 17, 2025

Could you please reorganize this PR into one commit per affected Clause, and then format each commit message as per https://github.com/cplusplus/draft/wiki/Commit-message-format?

@frederick-vs-ja frederick-vs-ja force-pushed the functions-members-constructors branch from abf59f7 to c12c964 Compare June 18, 2025 02:20
@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 18, 2025

@jensmaurer for a core perspective?

@tkoeppe tkoeppe requested a review from jensmaurer June 18, 2025 07:26
@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jul 24, 2025
@frederick-vs-ja frederick-vs-ja force-pushed the functions-members-constructors branch from c12c964 to bfa24db Compare July 25, 2025 14:07
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jul 25, 2025
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a redundancy / clarity improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants