-
Notifications
You must be signed in to change notification settings - Fork 781
Clarify functions, member functions, and constructors #6946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frederick-vs-ja
wants to merge
7
commits into
cplusplus:main
Choose a base branch
from
frederick-vs-ja:functions-members-constructors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Clarify functions, member functions, and constructors #6946
frederick-vs-ja
wants to merge
7
commits into
cplusplus:main
from
frederick-vs-ja:functions-members-constructors
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwakely
reviewed
Apr 23, 2024
Could you please reorganize this PR into one commit per affected Clause, and then format each commit message as per https://github.com/cplusplus/draft/wiki/Commit-message-format? |
abf59f7
to
c12c964
Compare
jwakely
approved these changes
Jun 18, 2025
@jensmaurer for a core perspective? |
…lat.set.overview], [flat.multiset.overview] A constructor is a member function
c12c964
to
bfa24db
Compare
jensmaurer
approved these changes
Jul 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a redundancy / clarity improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't say "constructors and/or member functions", "functions name or member function name". or "function or constructor" etc., because
I'm not very sure of the last point. But as a constexpr constructor is considered to be a constexpr function, I think it's consistent to say a constructor is a function.