Skip to content

fix: add package write permission #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

fix: add package write permission #255

merged 1 commit into from
Jul 9, 2025

Conversation

shenxianpeng
Copy link
Contributor

@shenxianpeng shenxianpeng commented Jul 9, 2025 •
edited by coderabbitai bot
Loading

closes #247

Summary by CodeRabbit

  • Chores
    • Updated workflow permissions to improve support for publishing Docker images to the GitHub Container Registry.

@shenxianpeng shenxianpeng added the bug Something isn't working label Jul 9, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 9, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The workflow configuration in .github/workflows/publish-image.yml was updated to grant the workflow packages: write permission in addition to the existing contents: read, enabling the workflow to push Docker images to GitHub Container Registry.

Changes

File(s) Change Summary
.github/workflows/publish-image.yml Added packages: write to workflow permissions

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant GitHub Actions Workflow
    participant GitHub Container Registry (ghcr.io)

    Developer->>GitHub Actions Workflow: Trigger publish-image workflow
    GitHub Actions Workflow->>GitHub: Authenticate with `contents: read` and `packages: write`
    GitHub Actions Workflow->>GitHub Container Registry (ghcr.io): Push Docker image
    GitHub Container Registry (ghcr.io)-->>GitHub Actions Workflow: Accept image (write permission)
Loading

Assessment against linked issues

Objective Addressed Explanation
Update workflow permissions to allow publishing Docker images to ghcr.io (#247) ✅

Possibly related PRs

Poem

🐇
With a hop and a skip, permissions set right,
Now Docker can travel, no error in sight.
To ghcr it goes,
Where the container now flows—
A rabbit’s delight on this workflow night!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55b000f and 8b3ff44.

📒 Files selected for processing (1)
  • .github/workflows/publish-image.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@shenxianpeng shenxianpeng marked this pull request as ready for review July 9, 2025 22:48
@shenxianpeng shenxianpeng requested a review from a team as a code owner July 9, 2025 22:48
@shenxianpeng shenxianpeng merged commit 9d219e9 into main Jul 9, 2025
7 of 8 checks passed
@shenxianpeng shenxianpeng deleted the bugfix/update-docker-images branch July 9, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish docker images to ghcr.io failed
1 participant
@shenxianpeng