-
Notifications
You must be signed in to change notification settings - Fork 48
docs: Refactor documentation to use Markdown with CSS-based components #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: Refactor documentation to use Markdown with CSS-based components #467
Conversation
Caution Review failedFailed to post review comments. Configuration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings
🔍 MCP Research (1 server)Linear: - CSS modules (e.g.,
🔇 Additional comments (1)
WalkthroughThis update introduces a new CSS module for the YAML editor with dark and light themes, enhances the YAML editor component by changing the Ace Editor theme and styling options, and significantly expands global CSS with extensive theming, responsive design, and custom styles for markdown elements, tables, admonitions, code blocks, and integration grids. No public APIs or exports were changed. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant YamlEditor (TSX)
participant AceEditor
participant YamlEditor.module.css
User->>YamlEditor (TSX): Open YAML editor
YamlEditor (TSX)->>AceEditor: Render editor with "terminal" theme, custom options
YamlEditor (TSX)->>YamlEditor.module.css: Apply theme-specific and responsive styles
User->>AceEditor: Edit YAML content
AceEditor->>YamlEditor (TSX): Trigger onChange event
YamlEditor (TSX)->>AceEditor: Parse YAML (non-strict), update state
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes Poem
Pre-Merge Checks (3 warnings)❌ Failed Checks (3 warnings)
Impact AnalysisYAML editor theme and parsing behavior updated📢 Medium 🔄 Impacts behavior The YAML editor component now uses a custom CSS module for container and editor styling, switches the AceEditor theme from “github” to “terminal”, applies new monospace font settings, and removes the Verify that the new “terminal” theme and CSS module classes render correctly in both light and dark modes, ensure the font settings apply as expected, and review the impact of removing strict parsing on invalid YAML inputs. Test the YAML editor in light and dark themes across supported browsers and screen sizes; verify syntax highlighting, cursor and selection styling, and confirm that formerly strict parse errors now succeed or fail appropriately. 🔍 Related Files
Extensive theming and responsive styling for markdown and UI components📢 Medium 🔄 Impacts behavior Added numerous CSS custom properties and style rules in Review the new CSS variable definitions and high-specificity selectors for conflicts or unintended overrides, and ensure media query breakpoints and theme toggles behave as intended. Manually verify pages containing tables, blockquotes, admonitions, code samples, integration grids, and list sections in both light and dark themes and on mobile, tablet, and desktop widths to confirm visual consistency and responsiveness. 🔍 Related Files
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@jmacdotorg looks like this is still pending review, but does the updated architecture align with what you had in mind? @PrasadBhat4 thank you for the quick turnaround! Would love to see a preview branch when possible. (no idea why it's not building, does it have to do with node.js CI failing?) |
Hi @edgarcerecerez , Thanks for your patience with the CI issues! Regarding the error, this is a GitHub Actions permission issue with the |
Hi @edgarcerecerez , I noticed there's a duplicate page with the title "Control administrative access" appearing in 2 sections on the live site. Is this expected behavior, or should we consolidate these into a single page? Just wanted to flag this in case it needs to be addressed as part of the documentation updates. ![]() Thanks! |
By overriding the custom CSS for the Docusaurus code blocks, I have successfully achieved the desired design implementation. I will push the changes after testing it. Please wait until I push the changes for your review. |
Good catch @PrasadBhat4, looks like it's the same page but shows in two places in the ToC. You're right, we'll be addressing it as part of the ToC updates soon. The first step is to get that design update live :) cc: @jmacdotorg |
0998bd6
to
d9ea05d
Compare
This is so much cleaner. Great feedback @jmacdotorg ! 🙌 |
📋 Overview
This PR enhances the documentation styling by overriding default Docusaurus component styles to achieve improved visual design and responsive behavior while maintaining the existing content
structure.
🔗 Related Issues
✨ Key Changes
🎨 Docusaurus Style Overrides
📱 Responsive Table Improvements
🌙 Dark Theme Support
🎯 Design System Consistency
📖 Content Preservation
🔧 Technical Improvements