-
Notifications
You must be signed in to change notification settings - Fork 9
Add security rules for detecting hard-coded secrets in TypeScript apps #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b90bbb1
express-session-hardcoded-secret-typescript
b5048b6
express-jwt-hardcoded-secret-typescript
33cb208
modification in express-jwt-hardcoded-secret-typescript
c50168b
modification in express-session-hardcoded-secret-typescript
3d5b961
modification in express-session-hardcoded-secret-typescript
195629e
modification in express-session-hardcoded-secret-typescript
a8dd9c0
Update express-session-hardcoded-secret-typescript
ESS-ENN 20c1708
Merge branch 'coderabbitai:main' into rules_122-124
ESS-ENN 2fffc18
Modification of express-jwt-hardcoded-secret-typescript
ESS-ENN cda340c
Modification in express-session-hardcoded-secret-typescript
ESS-ENN c5583c2
Added rule detect-angular-sce-disabled-typescript
ESS-ENN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
37 changes: 37 additions & 0 deletions
37
rules/typescript/security/detect-angular-sce-disabled-typescript.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
id: detect-angular-sce-disabled-typescript | ||
language: typescript | ||
severity: warning | ||
message: >- | ||
$sceProvider is set to false. Disabling Strict Contextual escaping | ||
(SCE) in an AngularJS application could provide additional attack surface | ||
for XSS vulnerabilities. | ||
note: >- | ||
[CWE-79] Improper Neutralization of Input During Web Page Generation. | ||
[REFERENCES] | ||
- https://docs.angularjs.org/api/ng/service/$sce | ||
- https://owasp.org/www-chapter-london/assets/slides/OWASPLondon20170727_AngularJS.pdf | ||
rule: | ||
kind: expression_statement | ||
regex: ^\$sceProvider | ||
has: | ||
kind: call_expression | ||
stopBy: end | ||
all: | ||
- has: | ||
kind: member_expression | ||
nthChild: 1 | ||
all: | ||
- has: | ||
kind: identifier | ||
regex: ^\$sceProvider$ | ||
- has: | ||
kind: property_identifier | ||
regex: ^enabled$ | ||
precedes: | ||
kind: arguments | ||
has: | ||
kind: 'false' | ||
nthChild: 1 | ||
not: | ||
has: | ||
nthChild: 2 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.