Skip to content

Add Ruby security rules for RSA key size, AWS SDK and Faraday secrets #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 19, 2025
+1,153 −0
Merged

Add Ruby security rules for RSA key size, AWS SDK and Faraday secrets #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
bb7b8e1
removed missing-secure-java
Dec 16, 2024
308e947
Merge branch 'coderabbitai:main' into main
ESS-ENN Jan 6, 2025
46efd55
Merge branch 'coderabbitai:main' into main
ESS-ENN Jan 8, 2025
3ac0204
Merge branch 'coderabbitai:main' into main
ESS-ENN Jan 8, 2025
7caba92
Merge branch 'coderabbitai:main' into main
ESS-ENN Jan 9, 2025
d3a2776
Merge branch 'coderabbitai:main' into main
ESS-ENN Jan 10, 2025
2e86380
Merge branch 'coderabbitai:main' into main
ESS-ENN Jan 14, 2025
b072db7
Merge branch 'coderabbitai:main' into main
ESS-ENN Jan 20, 2025
65dce29
Merge branch 'coderabbitai:main' into main
ESS-ENN Jan 22, 2025
12bb3aa
httponly-false-csharp
ESS-ENN Jan 22, 2025
2c5ea88
use-of-md5-digest-utils-java
ESS-ENN Jan 22, 2025
d3067f1
removing use-of-md5-digest-utils and httponly-false-csharp
ESS-ENN Jan 22, 2025
56d4011
Merge branch 'coderabbitai:main' into main
ESS-ENN Jan 28, 2025
f7f1d72
Merge branch 'coderabbitai:main' into main
ESS-ENN Jan 29, 2025
0d53f8e
Merge branch 'coderabbitai:main' into main
ESS-ENN Feb 4, 2025
b622bca
Merge branch 'coderabbitai:main' into main
ESS-ENN Feb 6, 2025
67459bf
Merge branch 'coderabbitai:main' into main
ESS-ENN Feb 7, 2025
b8b2adb
Merge branch 'coderabbitai:main' into main
ESS-ENN Feb 18, 2025
a8259dd
ruby-faraday-hardcoded-secret-ruby
ESS-ENN Feb 18, 2025
d0dab66
ruby-aws-sdk-hardcoded-secret-ruby
ESS-ENN Feb 18, 2025
1c4eecf
insufficient-rsa-key-size-ruby
ESS-ENN Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 91 additions & 0 deletions rules/ruby/security/insufficient-rsa-key-size-ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
id: insufficient-rsa-key-size-ruby
language: ruby
severity: warning
message: >-
The RSA key size $SIZE is insufficent by NIST standards. It is
recommended to use a key length of 2048 or higher.
note: >-
[CWE-326] Inadequate Encryption Strength.
[REFERENCES]
- https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-57Pt3r1.pdf

ast-grep-essentials: true

utils:
OpenSSL::PKey::RSA.generate($SIZE,...):
# OpenSSL::PKey::RSA.generate($SIZE,...)
kind: call
all:
- has:
stopBy: neighbor
kind: scope_resolution
regex: ^OpenSSL::PKey::RSA$
- has:
stopBy: neighbor
regex: ^.$
- has:
stopBy: neighbor
kind: identifier
regex: ^(new|generate)$
- has:
stopBy: neighbor
kind: argument_list
has:
pattern: $KEYS
any:
- regex: '^(-?(0|[1-9][0-9]?|[1-9][0-9]{2}|1[0-9]{3}|20[0-3][0-9]|204[0-7])(\.[0-9]+)?|0|-[1-9][0-9]*|-[1-9][0-9]{2,}|-1[0-9]{3}|-20[0-3][0-9]|-204[0-7])$'
- regex: ^-\d+(\.\d+)?(/(\d+(\.\d+)?))?$
nthChild:
position: 1
ofRule:
not:
kind: comment

OpenSSL::PKey::RSA.new($ASSIGN, ...):
# $ASSIGN = $SIZE
# OpenSSL::PKey::RSA.new($ASSIGN, ...)
kind: call
all:
- has:
stopBy: neighbor
kind: scope_resolution
regex: ^OpenSSL::PKey::RSA$
- has:
stopBy: neighbor
regex: ^.$
- has:
stopBy: neighbor
kind: identifier
regex: ^(new|generate)$
- has:
stopBy: neighbor
kind: argument_list
has:
stopBy: neighbor
pattern: $BIT
nthChild:
position: 1
ofRule:
not:
kind: comment
- any:
- inside:
stopBy: end
follows:
stopBy: end
kind: assignment
pattern: $BIT = $KEY
- follows:
stopBy: end
kind: assignment
pattern: $BIT = $KEY
rule:
kind: call
any:
- matches: OpenSSL::PKey::RSA.generate($SIZE,...)
- matches: OpenSSL::PKey::RSA.new($ASSIGN, ...)
constraints:
KEY:
any:
- regex: '^(-?(0|[1-9][0-9]?|[1-9][0-9]{2}|1[0-9]{3}|20[0-3][0-9]|204[0-7])(\.[0-9]+)?|0|-[1-9][0-9]*|-[1-9][0-9]{2,}|-1[0-9]{3}|-20[0-3][0-9]|-204[0-7])$'
- regex: ^-\d+(\.\d+)?(/(\d+(\.\d+)?))?$
149 changes: 149 additions & 0 deletions rules/ruby/security/ruby-aws-sdk-hardcoded-secret-ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
id: ruby-aws-sdk-hardcoded-secret-ruby
language: ruby
severity: warning
message: >-
A secret is hard-coded in the application. Secrets stored in source
code, such as credentials, identifiers, and other types of sensitive data,
can be leaked and used by internal or external malicious actors. Use
environment variables to securely provide credentials and other secrets or
retrieve them from a secure vault or Hardware Security Module (HSM).
note: >-
[CWE-798] Use of Hard-coded Credentials.
[REFERENCES]
- https://cheatsheetseries.owasp.org/cheatsheets/Secrets_Management_Cheat_Sheet.html

ast-grep-essentials: true

utils:
Aws::Credentials.new($X, "...", ...):
# Aws::Credentials.new($X, "...", ...)
kind: call
all:
- has:
stopBy: neighbor
kind: scope_resolution
regex: ^Aws::Credentials$
- has:
stopBy: neighbor
regex: ^.$
- has:
stopBy: neighbor
kind: identifier
regex: ^new$
- has:
stopBy: neighbor
kind: argument_list
has:
stopBy: neighbor
kind: string
nthChild:
position: 2
ofRule:
not:
kind: comment
any:
- has:
nthChild: 1
not:
kind: pair
has:
nthChild: 1
kind: hash_key_symbol

- any:
- inside:
stopBy: end
follows:
stopBy: end
kind: call
pattern: require 'aws-sdk-core'
- follows:
stopBy: end
kind: call
pattern: require 'aws-sdk-core'
Aws::Credentials.new($X, "...", ...)_instance:
# Aws::Credentials.new($X, $VAR, ...)
kind: call
all:
- has:
stopBy: neighbor
kind: scope_resolution
regex: ^Aws::Credentials$
- has:
stopBy: neighbor
regex: ^.$
- has:
stopBy: neighbor
kind: identifier
regex: ^new$
- has:
stopBy: neighbor
kind: argument_list
has:
stopBy: neighbor
kind: identifier
pattern: $VAR
nthChild:
position: 2
ofRule:
not:
kind: comment
any:
- has:
nthChild: 1
not:
kind: pair
has:
nthChild: 1
kind: hash_key_symbol
- any:
- follows:
stopBy: end
kind: assignment
all:
- has:
kind: identifier
pattern: $VAR
- has:
kind: string
has:
kind: string_content
- inside:
stopBy: end
follows:
stopBy: end
kind: assignment
all:
- has:
kind: identifier
pattern: $VAR
- has:
kind: string
has:
kind: string_content
- any:
- inside:
stopBy: end
follows:
stopBy: end
kind: call
pattern: require 'aws-sdk-core'
- follows:
stopBy: end
kind: call
pattern: require 'aws-sdk-core'

rule:
kind: call
any:
- matches: Aws::Credentials.new($X, "...", ...)
- matches: Aws::Credentials.new($X, "...", ...)_instance
all:
- not:
has:
stopBy: end
kind: ERROR
- not:
inside:
stopBy: end
kind: ERROR
Loading