fix: correct URL validation and centralize logic #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssncferreira
force-pushed
the
ssncferreira/fix-url-validation
branch
from
5a69fcb to
f8556e8
Compare
ssncferreira
force-pushed
the
ssncferreira/fix-url-validation
branch
from
f8556e8 to
38bc617
Compare
johnstcn
reviewed
Jul 21, 2025
johnstcn
approved these changes
Jul 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect URL validation logic previously used in URL definitions, where the attribute label (
s) was being parsed instead of the actual value. This bug caused invalid URLs to be silently accepted.Additionally, this PR introduces a shared
ValidateURLhelper function to remove duplication and ensure consistent behavior across all URL fields.Changes
url.Parse(s), now validating the actual value.ValidateURLhelper function for consistent and reusable validation.ValidateURL.