-
Notifications
You must be signed in to change notification settings - Fork 40
feat: gemini cli module #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@matifali PR ready for review |
Hey @35C4n0r! This is awesome!! Can you also get it working with tasks and provide a basic example snippet in the README? See https://registry.coder.com/templates/coder-labs/tasks-docker for an example template that uses the Tasks view |
On it 👍 |
Since this is a bounty claim, could you please provide the screen recording of this module being loaded into a workspace, and display the modules functionality as outlined in: #213 |
@DevelopmentCats it's already there in the description of the PR (It's a loom link). |
Co-authored-by: Atif Ali <me@matifali.dev>
loom updated in PR description |
Both #229 and this PR are ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me, but the only thing you are missing is an avatar and README for your namespace.
You can look at the coder registry namespace for reference.
|
The job is failing because of the missing README for the namespace, so we might need to wait on the tmux module commit before pushing this one but ultimately it looks good! |
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
Co-authored-by: Hugo Dutka <dutkahugo@gmail.com>
@DevelopmentCats @hugodutka tests updated. Ready for review. |
@35C4n0r can we put this under the coder-labs contributor instead of yours? We hope to support co-authoring so it can show up as both, but I want to associate the agent modules with the Coder name as we will ship updates/patches to them and there is no expectation for you to always do that :) |
@bpmct sure, refactoring it 👍🏻 |
@bpmct Done ! Please lmk if this needs any more changes. |
Closes #237
/claim #237
Description
https://www.loom.com/share/5b099c73935f4f87b8fdafe1509bb79d?sid=7fea43d6-86e9-45ae-9892-efeb3c820b82Updated: https://www.loom.com/share/62e907eae8544d8cbbe560d7f63bd02d?sid=201212fa-eb58-44b5-8706-8bf9c2c37433
Type of Change
Module Information
Path:
registry/coder-labs/modules/gemini
New version:
v1.0.0
Breaking change: [ ] Yes [ ] No
Testing & Validation
bun test
)bun run fmt
)Related Issues