fix: resolve failing filebrowser tests #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a duplicate `await` in the `filebrowser` module's test file, ensuring proper execution of the `executeScriptInContainer` function. Additionally, a baseline test has been added to validate the output of the script execution.
…t since it was causing failure because of empty password and is not needed since noauth is set
|
so I removed the admin user creation for logging into the file browser since it was failing the install due to new password requirements, and it was previously blank. Everything appears to work and install fine, but it still prompts with a login window, so I will look into how we can suppress that or a way to create an admin user with a simple password |
matifali
approved these changes
Jul 3, 2025
…setup in run script in order to satisfy fb user requirements
…r configuration since its done in cli
ssncferreira
added a commit
to coder/coder
that referenced
this pull request
Jul 8, 2025
Workspaces with `Write Coder on Coder` template are failing with an error in the agent related to File Browser: ``` 2025/07/08 14:00:29 Using database: /home/coder/filebrowser.db 2025/07/08 14:00:29 password is too short, minimum length is 12 ``` Updating filebrowser module version to 1.1.1: coder/registry#173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Module Information
Path:
registry/[namespace]/modules/filebrowserNew version:
v1.1.1Breaking change: [ ] Yes [X] No
Testing & Validation
bun test)bun run fmt)Related
(https://github.com/coder/registry/actions/runs/15975017391/job/45055105439?pr=160)