Skip to content

docs: clarify http or https required in url; count in deployment resource in template #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2023
Merged

docs: clarify http or https required in url; count in deployment resource in template #7

merged 1 commit into from
Jul 21, 2023
+3 −2

Conversation

sharkymark
Copy link
Contributor

This PR addresses a couple gotchas when using logstream:

  1. http or https is required in the helm values
  2. A count is required in the template deployment or the pod will create on a workspace stop

@sharkymark sharkymark requested a review from kylecarbs July 21, 2023 15:05
@kylecarbs kylecarbs merged commit a41c03a into main Jul 21, 2023
@kylecarbs kylecarbs deleted the docs-https-url branch July 21, 2023 15:24
@ericpaulsen ericpaulsen mentioned this pull request Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharkymark @kylecarbs