impl: enhanced workflow for network disruptions #162
Conversation
Currently, when the network connection drops, the Coder TBX plugin resets itself, redirects users to the authentication page, and terminates active SSH sessions to remote IDEs. This disrupts the user experience, forcing users to manually reconnect once the network is restored. Additionally, since the SSH session to the remote IDE is lost, the JBClient is unable to re-establish a connection with the remote backend. This PR aims to improve that experience by adopting a behavior similar to the SSH plugin. Instead of clearing the list of workspaces or dropping existing SSH sessions during a network outage, we retain them. Once the network is restored, the plugin will automatically reinitialize the HTTP client and regenerate the SSH configuration—only if the number of workspaces has changed during the disconnection—without requiring user intervention.
Adds support for remembering SSH connections that were not manually disconnected by the user. This allows the plugin to automatically restore those connections on the next startup enabling remote IDEs that remained open to reconnect once the SSH link is re-established.
| if (isManual) { | ||
| // if the user manually disconnects the ssh connection we should not connect automatically | ||
| context.settingsStore.updateAutoConnect(this.id, false) | ||
| } |
There was a problem hiding this comment.
Why this choice? If the user manually disconnects and then connects again, we should still try to resume the last active connection if possible.
There was a problem hiding this comment.
If you take a look at beforeConnection we set auto-connect to true. In other words:
- user connects the ssh, and then TBX is closed -> at the next restart we automatically reconnect.
- user connects to the ssh, manually disconnects and then TBX is closed -> at the next restart we no longer reconnect automatically because the user made a conscious choice to disconnect.
- user connects to the ssh, manually disconnects, then reconnects again the ssh session, and then TBX is closed -> at the next restart we automatically reconnect.
|
Tested on macOS with both Coder Desktop and without, and the connection seems to recover gracefully. I noticed some delay (5-10s) in showing |
This looks like it is under JetBrains control. I can reproduce the same thing with the SSH plugin. The "Connecting" is a state from from JetBrains. |
Auto connect will now happen everytime at start up if there is a url and token available.
Reason for the major change: major changes in how we handle network disruptions
Currently, when the network connection drops, the Coder TBX plugin resets itself, redirects users to the authentication page, and terminates active SSH sessions to remote IDEs. This disrupts the user experience, forcing users to manually reconnect once the network is restored. Additionally, since the SSH session to the remote IDE is lost, the JBClient is unable to re-establish a connection with the remote backend.
This PR aims to improve that experience by adopting a behavior similar to the SSH plugin. Instead of clearing the list of workspaces or dropping existing SSH sessions during a network outage, we retain them. Once the network is restored, the plugin will automatically reinitialize the HTTP client and regenerate the SSH configuration—only if the number of workspaces has changed during the disconnection—without requiring user intervention.
Additionally we also add support for remembering SSH connections that were not manually disconnected by the user. This allows the plugin to automatically restore those connections on the next startup enabling remote IDEs that remained open to reconnect once the SSH link is re-established.