fix: opt-in tailscale vpn loop prevention #148
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <summary> | ||
| /// When this is true Coder Connect will not attempt to protect against Tailscale loopback issues. | ||
| /// </summary> | ||
| public bool DisableTailscaleLoopProtection { get; set; } |
There was a problem hiding this comment.
Maybe EnableCorporateVpnSupport
| @@ -44,6 +44,12 @@ | |||
| > | |||
| <ToggleSwitch IsOn="{x:Bind ViewModel.ConnectOnLaunch, Mode=TwoWay}" /> | |||
| </controls:SettingsCard> | |||
| <controls:SettingsCard Description="This setting controls whether Coder Connect should bypass VPN loop preventation mechanism. Turn this ON only when dealing with a Coder deployment behind a corporate VPN." | |||
| Header="Disable corporate VPN loop protection" | |||
There was a problem hiding this comment.
Suggested change
| Header="Disable corporate VPN loop protection" | |
| Header="Enable support for corporate VPNs" |
| @@ -44,6 +44,12 @@ | |||
| > | |||
| <ToggleSwitch IsOn="{x:Bind ViewModel.ConnectOnLaunch, Mode=TwoWay}" /> | |||
| </controls:SettingsCard> | |||
| <controls:SettingsCard Description="This setting controls whether Coder Connect should bypass VPN loop preventation mechanism. Turn this ON only when dealing with a Coder deployment behind a corporate VPN." | |||
There was a problem hiding this comment.
Suggested change
| <controls:SettingsCard Description="This setting controls whether Coder Connect should bypass VPN loop preventation mechanism. Turn this ON only when dealing with a Coder deployment behind a corporate VPN." | |
| <controls:SettingsCard Description="This setting loosens some VPN loop protection checks in Coder Connect, allowing traffic to flow to a Coder deployment behind a corporate VPN. We do not recommend enabling this option if your deployment is not behind a corporate VPN." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.