fix: prompt for sign in when toggling coder connect on

ethanndickson · ethanndickson · commit 2012727235ae · 2025-07-24T01:23:22.000+10:00
diff --git a/Coder-Desktop/Coder-Desktop/Views/VPN/VPNMenu.swift b/Coder-Desktop/Coder-Desktop/Views/VPN/VPNMenu.swift
@@ -117,12 +117,15 @@ struct VPNMenu<VPN: VPNService, FS: FileSyncDaemon>: View {
     }
 
     private var vpnDisabled: Bool {
-        vpn.state == .connecting ||
-            vpn.state == .disconnecting ||
-            // Prevent starting the VPN before the user has approved the system extension.
-            vpn.state == .failed(.systemExtensionError(.needsUserApproval)) ||
-            // Prevent starting the VPN without a VPN configuration.
-            vpn.state == .failed(.networkExtensionError(.unconfigured))
+        // Always enabled if signed out, as that will open the sign in window
+        state.hasSession && (
+            vpn.state == .connecting ||
+                vpn.state == .disconnecting ||
+                // Prevent starting the VPN before the user has approved the system extension.
+                vpn.state == .failed(.systemExtensionError(.needsUserApproval)) ||
+                // Prevent starting the VPN without a VPN configuration.
+                vpn.state == .failed(.networkExtensionError(.unconfigured))
+        )
     }
 }
 
diff --git a/Coder-Desktop/Coder-DesktopTests/VPNMenuTests.swift b/Coder-Desktop/Coder-DesktopTests/VPNMenuTests.swift
@@ -59,6 +59,7 @@ struct VPNMenuTests {
     @Test
     func testVPNDisabledWhileConnecting() async throws {
         vpn.state = .disabled
+        state.login(baseAccessURL: URL(string: "https://coder.example.com")!, sessionToken: "fake-token")
 
         try await ViewHosting.host(view) {
             try await sut.inspection.inspect { view in
@@ -79,6 +80,7 @@ struct VPNMenuTests {
     @Test
     func testVPNDisabledWhileDisconnecting() async throws {
         vpn.state = .disabled
+        state.login(baseAccessURL: URL(string: "https://coder.example.com")!, sessionToken: "fake-token")
 
         try await ViewHosting.host(view) {
             try await sut.inspection.inspect { view in
