fix: prompt for sign in when toggling coder connect on

ethanndickson · ethanndickson · commit 1b6c9491bf63 · 2025-07-24T01:07:16.000+10:00
diff --git a/Coder-Desktop/Coder-Desktop/Views/VPN/VPNMenu.swift b/Coder-Desktop/Coder-Desktop/Views/VPN/VPNMenu.swift
@@ -117,12 +117,14 @@ struct VPNMenu<VPN: VPNService, FS: FileSyncDaemon>: View {
     }
 
     private var vpnDisabled: Bool {
+        // Always enabled if signed out, as that will open the sign in window
+        state.hasSession && (
         vpn.state == .connecting ||
             vpn.state == .disconnecting ||
             // Prevent starting the VPN before the user has approved the system extension.
             vpn.state == .failed(.systemExtensionError(.needsUserApproval)) ||
             // Prevent starting the VPN without a VPN configuration.
-            vpn.state == .failed(.networkExtensionError(.unconfigured))
+            vpn.state == .failed(.networkExtensionError(.unconfigured)))
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -117,12 +117,14 @@ struct VPNMenu<VPN: VPNService, FS: FileSyncDaemon>: View {`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`private var vpnDisabled: Bool {`
	`120`	`+ // Always enabled if signed out, as that will open the sign in window`
	`121`	`+ state.hasSession && (`
`120`	`122`	`vpn.state == .connecting \|\|`
`121`	`123`	`vpn.state == .disconnecting \|\|`
`122`	`124`	`// Prevent starting the VPN before the user has approved the system extension.`
`123`	`125`	`vpn.state == .failed(.systemExtensionError(.needsUserApproval)) \|\|`
`124`	`126`	`// Prevent starting the VPN without a VPN configuration.`
`125`		`- vpn.state == .failed(.networkExtensionError(.unconfigured))`
	`127`	`+ vpn.state == .failed(.networkExtensionError(.unconfigured)))`
`126`	`128`	`}`
`127`	`129`	`}`
`128`	`130`