fix: fix nil pointer dereference in ReportTask #19045
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasK33
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug related to a nil pointer dereference in the task reporting functionality.
Bug Fixes and Error Handling:
RegisterToolsinmcp.goto skip registering theReportTasktool in the remote MCP context when a task reporter is not configured, preventing potential nil pointer dereference panics.toolsdk.goto ensure task reporting dependencies are available before invoking the reporter, returning an appropriate error if not.Test Coverage:
TestReportTaskNilPointerDerefintoolsdk_test.goto verify that the system does not panic when task reporting dependencies are missing and instead returns a clear error message.TestReportTaskWithReporterintoolsdk_test.goto validate correct behavior when a task reporter is configured, ensuring the handler processes the request as expected.