feat: support shift+enter in terminal #19021
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
force-pushed
the
asher/shift+enter
branch
from
b679993 to
aa18faf
Compare
code-asher
changed the title
code-asher
force-pushed
the
asher/shift+enter
branch
2 times, most recently
from
5fd3af9 to
1ad508f
Compare
It acts the same alt+enter, but is more familiar to users.
code-asher
force-pushed
the
asher/shift+enter
branch
from
1ad508f to
963f4d0
Compare
BrunoQuaresma
approved these changes
Jul 24, 2025
| @@ -270,6 +287,7 @@ const TerminalPage: FC = () => { | |||
| .withBackoff(new ExponentialBackoff(1000, 6)) | |||
| .build(); | |||
| websocket.binaryType = "arraybuffer"; | |||
| websocketRef.current = websocket; | |||
There was a problem hiding this comment.
Why do you need to do this? It looks strange to me.
There was a problem hiding this comment.
attachCustomKeyEventHandler has no disposer, so we can only add it once, which means I have to do it when we create the terminal (if I did it here we would create additional handlers on every reconnect). But that means I need a stable reference to the websocket.
Is there another way of doing this maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It acts the same alt+enter, but is more familiar to users.
Closes #18864