Skip to content

fix: use httponly flag on coder_signed_app_token cookie #18989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

deansheather
Copy link
Member

This cookie is only used by the server, not by any JS code anywhere.

Copy link
Contributor

@jdomeracki-coder jdomeracki-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, as discussed on Discord

@deansheather deansheather merged commit 62dc831 into main Jul 22, 2025
33 checks passed
@deansheather deansheather deleted the dean/cookie-http-only branch July 22, 2025 12:44
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants