Skip to content

fix: debounce slider to avoid laggy behavior #18980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 22, 2025
Merged

fix: debounce slider to avoid laggy behavior #18980

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d1d08d
fix: debounce slider to avoid laggy behavior
jaaydenh Jul 21, 2025
b2f30fc
fix: format
jaaydenh Jul 21, 2025
4980780
fix: slider improvements
jaaydenh Jul 21, 2025
24cf657
fix: format
jaaydenh Jul 21, 2025
f7c8dcc
fix: handle dynamic defaults correct for debounced parameters
jaaydenh Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 30 additions & 26 deletions site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,14 @@ export const DynamicParameter: FC<DynamicParameterProps> = ({
/>
<div className="max-w-lg">
{parameter.form_type === "input" ||
parameter.form_type === "textarea" ? (
parameter.form_type === "textarea" ||
parameter.form_type === "slider" ? (
<DebouncedParameterField
id={id}
parameter={parameter}
value={value}
onChange={onChange}
disabled={disabled}
isPreset={isPreset}
/>
) : (
<ParameterField
Expand Down Expand Up @@ -250,7 +250,6 @@ interface DebouncedParameterFieldProps {
onChange: (value: string) => void;
disabled?: boolean;
id: string;
isPreset?: boolean;
}

const DebouncedParameterField: FC<DebouncedParameterFieldProps> = ({
Expand All @@ -259,7 +258,6 @@ const DebouncedParameterField: FC<DebouncedParameterFieldProps> = ({
onChange,
disabled,
id,
isPreset,
}) => {
const [localValue, setLocalValue] = useState(
value !== undefined ? value : validValue(parameter.value),
Expand All @@ -271,13 +269,13 @@ const DebouncedParameterField: FC<DebouncedParameterFieldProps> = ({
const prevDebouncedValueRef = useRef<string | undefined>();
const prevValueRef = useRef(value);

// This is necessary in the case of fields being set by preset parameters
// Necessary for dynamic defaults or fields being set by preset parameters
useEffect(() => {
if (isPreset && value !== undefined && value !== prevValueRef.current) {
if (value !== undefined && value !== prevValueRef.current) {
setLocalValue(value);
prevValueRef.current = value;
}
}, [value, isPreset]);
}, [value]);

useEffect(() => {
// Only call onChangeEvent if debouncedLocalValue is different from the previously committed value
Expand Down Expand Up @@ -408,6 +406,31 @@ const DebouncedParameterField: FC<DebouncedParameterFieldProps> = ({
</Stack>
);
}

case "slider": {
const numericValue = Number.isFinite(Number(localValue))
? Number(localValue)
: 0;
const { validation_min: min = 0, validation_max: max = 100 } =
parameter.validations[0] ?? {};

return (
<div className="flex flex-row items-baseline gap-3">
<Slider
id={id}
className="mt-2"
value={[numericValue]}
onValueChange={([value]) => {
setLocalValue(value.toString());
}}
min={min ?? undefined}
max={max ?? undefined}
disabled={disabled}
/>
<span className="w-4 font-medium">{numericValue}</span>
</div>
);
}
}
};

Expand Down Expand Up @@ -564,25 +587,6 @@ const ParameterField: FC<ParameterFieldProps> = ({
</div>
);

case "slider":
return (
<div className="flex flex-row items-baseline gap-3">
<Slider
id={id}
className="mt-2"
value={[Number.isFinite(Number(value)) ? Number(value) : 0]}
onValueChange={([value]) => {
onChange(value.toString());
}}
min={parameter.validations[0]?.validation_min ?? 0}
max={parameter.validations[0]?.validation_max ?? 100}
disabled={disabled}
/>
<span className="w-4 font-medium">
{Number.isFinite(Number(value)) ? value : "0"}
</span>
</div>
);
case "error":
return <Diagnostics diagnostics={parameter.diagnostics} />;
}
Expand Down
Loading