feat: add managed agent license limit checks #18937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a query for counting managed agent workspace builds between two timestamps - The "Actual" field in the feature entitlement for managed agents is now populated with the value read from the database - The wsbuilder package now validates AI agent usage against the limit when a license is installed
deansheather
changed the title
dannykopping
approved these changes
Jul 21, 2025
| @@ -279,7 +281,7 @@ func (e *Executor) runOnce(t time.Time) Stats { | |||
| } | |||
|
|
|||
| if nextTransition != "" { | |||
| builder := wsbuilder.New(ws, nextTransition). | |||
| builder := wsbuilder.New(ws, nextTransition, *e.buildUsageChecker.Load()). | |||
There was a problem hiding this comment.
This could panic; can you add some protection for it?
There was a problem hiding this comment.
The atomic pointer is preloaded with a value before the AGPL API gets constructed, so there's no opportunity for it to be misused or ever hold nil. We also have many other atomic pointers that get dereferenced like this, such as *api.Auditor.Load() which is used in every auditable API endpoint.
| @@ -335,7 +335,7 @@ func (api *API) postWorkspaceBuilds(rw http.ResponseWriter, r *http.Request) { | |||
| return | |||
| } | |||
|
|
|||
| builder := wsbuilder.New(workspace, database.WorkspaceTransition(createBuild.Transition)). | |||
| builder := wsbuilder.New(workspace, database.WorkspaceTransition(createBuild.Transition), *api.BuildUsageChecker.Load()). | |||
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the code is new tests and updating old ones.
Closes coder/internal#777