chore: add managed ai usage consumption to license view #18934
+292
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/ManagedAgentsConsumption.stories.tsx
Show resolved
Hide resolved
site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/ManagedAgentsConsumption.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/ManagedAgentsConsumption.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/ManagedAgentsConsumption.tsx
Show resolved
Hide resolved
site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/ManagedAgentsConsumption.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/ManagedAgentsConsumption.tsx
Outdated
Show resolved
Hide resolved
ibetitsmike
force-pushed
the
mike/add-managed-ai-usage-to-license-view
branch
from
1bb6714 to
bcb7faa
Compare
aslilac
reviewed
Jul 22, 2025
There was a problem hiding this comment.
- The "Disabled" story shows NaN on the page which seems like a bug
- I would expect the "near limit" bar to not be green anymore. Maybe yellow or orange instead.
- You've got a mixture of Tailwind styles and Emotion styles in the
ManagedAgentsConsumptioncomponent. New use of Emotion is discouraged, please just use Tailwind (but using thestyleprop for the percentage math is correct) - It feels weird the have the bar "full" when it's only visually 50% filled. I wonder if the usage bar should be non-linear. For example the first 80% could always be in the range
[0, softLimit]and the last 20% could be in the range[softLimit, hardLimit].
Comment on lines
+54
to
+56
| const managedAgentLimitStarts = managedAgentFeature?.usage_period?.start; | ||
| const managedAgentLimitExpires = managedAgentFeature?.usage_period?.end; | ||
| const managedAgentFeatureEnabled = managedAgentFeature?.enabled; |
There was a problem hiding this comment.
The only place these variables are used is to be passed in to ManagedAgentsConsumption. Why does that component take all of the values individually rather than just taking a Feature?
Comment on lines
+163
to
+168
| usage={managedAgentFeature.actual || 0} | ||
| included={managedAgentFeature.soft_limit || 0} | ||
| limit={managedAgentFeature.limit || 0} | ||
| startDate={managedAgentLimitStarts || ""} | ||
| endDate={managedAgentLimitExpires || ""} | ||
| enabled={managedAgentFeatureEnabled} |
There was a problem hiding this comment.
...and then we don't need to do this defaulting here. we should do some validation inside of this component and return null or an <ErrorAlert> if the feature passed in is incorrect.
Comment on lines
+86
to
+87
| Managed agents are counted based on the amount of successfully | ||
| started workspaces with an AI agent. |
There was a problem hiding this comment.
Suggested change
| Managed agents are counted based on the amount of successfully | |
| started workspaces with an AI agent. | |
| Managed agents are counted based on the amount of running | |
| workspaces with an AI agent. |
| className="rounded-[2px] bg-highlight-green size-3 inline-block" | ||
| aria-label="Legend for current usage in the chart" | ||
| /> | ||
| Amount of started workspaces with an AI agent. |
There was a problem hiding this comment.
Suggested change
| Amount of started workspaces with an AI agent. | |
| Running workspaces with an AI agent |
I feel like legend items don't usually have punctuation at the end
| className="rounded-[2px] bg-content-disabled size-3 inline-block" | ||
| aria-label="Legend for included allowance in the chart" | ||
| /> | ||
| Included allowance from your current license plan. |
There was a problem hiding this comment.
Suggested change
| Included allowance from your current license plan. | |
| Allowance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers with licenses not supporting managed AI agents will receive the following information:
Customers with active licenes for managed AI agents will see:
Closes coder/internal#813