feat: add logo SVG and replace inline SVG with image reference #18930
+5
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization page Change-Id: Iad1117eaa5b83a223bd8fbd91f006880ec9a7569 Signed-off-by: Thomas Kosiewski <tk@coder.com>
matifali
approved these changes
Jul 21, 2025
ThomasK33
deleted the
thomask33/07-21-chore_replace_inline_svg_with_updated_logo.svg_file_in_oauth2_authorization_page
branch
aslilac
reviewed
Jul 21, 2025
There was a problem hiding this comment.
this file already existed at /icon/coder.svg, why didn't we use that?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace SVG with external logo file in OAuth2 authorization page
This PR replaces the inline SVG logo in the OAuth2 authorization page with a reference to an external SVG file. The change:
logo.svgfile in the static directory with the Coder logoThis approach improves maintainability by centralizing the logo in a single file and reduces duplication in the codebase.