refactor: simplify OAuth2 authorization flow and use 302 redirects #18923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasK33
force-pushed
the
thomask33/07-20-refactor_oauth2_simplify_authorization_flow_by_removing_middleware_layer
branch
from
ee2ff90 to
6f159c6
Compare
bpmct
approved these changes
Jul 20, 2025
…layer Change-Id: Ieff16b08aeb2cf2357ada11d83fd408cc66c6c5a Signed-off-by: Thomas Kosiewski <tk@coder.com>
ThomasK33
force-pushed
the
thomask33/07-20-refactor_oauth2_simplify_authorization_flow_by_removing_middleware_layer
branch
from
6f159c6 to
3f20259
Compare
ThomasK33
deleted the
thomask33/07-20-refactor_oauth2_simplify_authorization_flow_by_removing_middleware_layer
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor OAuth2 Provider Authorization Flow
This PR refactors the OAuth2 provider authorization flow by:
authorizeMWmiddleware and directly implementing its functionality in theShowAuthorizePagehandlerdbparameter fromShowAuthorizePageaccessURLparameter fromProcessAuthorizeProcessAuthorizefrom 307 (Temporary Redirect) to 302 (Found) to improve compatibility with external OAuth2 apps and browsers. (Technical explanation: we replied with a 307 to a POST request, thus the browser performs a redirect to that URL as a POST request, but we need it to be a GET request to be compatible. Thus, we use the 302 redirect so that browsers turn it into a GET request when redirecting back to the redirect_uri.)The changes maintain the same functionality while simplifying the code and improving compatibility with external systems.