feat: add workspace_apps configuration to control apps in workspace table #18922
Conversation
![blink-so[bot]](https://avatars.githubusercontent.com/in/1271127?s=60&v=4){kind=small}
Updated the button labels on the /workspaces page to clearly indicate that VS Code opens in the browser, matching the UI mockup provided.
…pace table - Added workspace_apps field to terraform coder_agent resource - Updated proto definition to include workspace_apps - Modified frontend WorkspaceApps component to respect configured apps - Allows specifying which apps (built-in and custom) appear in the workspace table - Maximum of 4 apps displayed, in the order specified
blink-so
bot
requested review from
aslilac,
spikecurtis and
johnstcn
as code owners
- Add database migration for workspace_apps column - Update SQL queries to include workspace_apps - Update provisioner server to pass workspace_apps from terraform - Still needs: database code regeneration and API updates
Add workspace_apps configuration to control which apps appear in workspace table: - Add database migration for workspace_apps column - Update WorkspaceAgent struct to include workspace_apps field - Update SQL queries to handle workspace_apps - Add comprehensive tests for the new functionality - Add documentation with examples This allows administrators to configure via Terraform which apps appear as action buttons in the workspace table while maintaining backward compatibility.
blink-so
bot
force-pushed
the
feat/configurable-display-app-icons
branch
from
0c281d9 to
eb77a5e
Compare
This ensures the generated database code includes the workspace_apps field needed for the feature to compile properly.
|
This can be controlled with |
There was a problem hiding this comment.
Is the intention here to allow full customization of the apps shown in the workspace list as opposed to the workspace details? Having a different ordering on the list as opposed to the details page seems potentially confusing.
Instead of adding yet another field on our provider, an alternative solution could be to simply include the first four coder_app instances based on the order field and what is set in display_apps. I'd suggest display_apps taking priority and then 'filling in' the remainder with the top N coder_apps based on order (up to max 4 apps).
EDIT: this appears to be the current logic. We first prioritize the 'built-in apps' and then fill in the remaining 'slots' with any healthy non-hidden user apps.
This PR adds the ability to configure which apps appear in the workspace table on the /workspaces page via terraform.
Changes
workspace_appsfield to thecoder_agentterraform resourceUsage Example
Implementation Notes
TODO
Requested by @jacqueline in Slack.