Skip to content

fix(site): only attempt to watch when dev containers enabled #18892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywood DanielleMaywood commented Jul 15, 2025

When an agent has explicitly disable the dev container integration, we currently show an ugly error when watching for containers inevitably fails. Instead, we now detect when the initial list fails due to the integration being disabled, and not attempt to begin watching.

@DanielleMaywood DanielleMaywood marked this pull request as ready for review July 15, 2025 22:43
@DanielleMaywood DanielleMaywood requested a review from aslilac as a code owner July 15, 2025 22:43
@DanielleMaywood DanielleMaywood requested a review from aslilac July 16, 2025 22:32
@DanielleMaywood DanielleMaywood merged commit bfb9aa4 into main Jul 16, 2025
29 of 31 checks passed
@DanielleMaywood DanielleMaywood deleted the danielle/do-not-watch-if-disabled branch July 16, 2025 23:04
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants