feat: add customizable signups disabled text for all authentication methods #18887
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blink-so[bot]](https://avatars.githubusercontent.com/in/1271127?s=60&v=4){kind=small}
…ethods This change adds a general --signups-disabled-text configuration option that allows administrators to customize the message shown when signups are disabled, regardless of the authentication method used. Changes: - Add SignupsDisabledText field to DeploymentValues struct - Add --signups-disabled-text CLI flag and CODER_SIGNUPS_DISABLED_TEXT env var - Update userauth logic to use general text with OIDC fallback for backward compatibility - Add new User Authentication deployment group for general auth settings - Support Markdown formatting in the custom text This enhances the existing OIDC-specific signups disabled text to work with all authentication methods, providing better flexibility for administrators to inform users about signup policies. Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
- Update CLI documentation with new --signups-disabled-text flag - Add USER AUTHENTICATION section to enterprise help golden file - Update TypeScript types with signups_disabled_text field Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Remove extra blank lines and ensure files end with exactly one newline Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Add blank lines after titles and before sections to match linter expectations Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Add missing blank lines after '## Usage' sections in CLI documentation files to match the expected formatting from make gen. Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Run CLI documentation generation using the project's clidocgen tool to ensure proper formatting and structure that matches CI expectations. Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Run clidocgen followed by markdownlint-cli2 and markdown-table-formatter to match the exact formatting that CI expects. Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Format docs/manifest.json with biome and include the generated documentation for the new --signups-disabled-text CLI flag. Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a general
--signups-disabled-textconfiguration option that allows administrators to customize the message shown when signups are disabled, regardless of the authentication method used.Changes
DeploymentValuesstruct with CLI flag--signups-disabled-textand environment variableCODER_SIGNUPS_DISABLED_TEXTBenefits
Usage
The general setting takes precedence over the OIDC-specific setting, ensuring consistent messaging across all authentication methods while maintaining backward compatibility.
Tested: Code compiles successfully and maintains existing functionality.