feat: add configurable SSH host key algorithm support #18866
+49
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blink-so[bot]](https://avatars.githubusercontent.com/in/1271127?s=60&v=4){kind=small}
Adds support for configurable SSH host key algorithms to improve compatibility with modern SSH clients like Visual Studio 2022. Changes: - Add HostKeyAlgorithm field to agentssh.Config - Implement Ed25519 key generation in CoderSigner function - Add CLI flag --ssh-host-key-algorithm with env var support - Support both 'rsa' (default) and 'ed25519' algorithms - Maintain backward compatibility with RSA as default Resolves compatibility issues with SSH clients that no longer support RSA host keys. Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Remove trailing whitespace from empty lines in agentssh.go to satisfy the formatting requirements. Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
|
@blink instead of making it configurable, can't we just support both algorithms simultaneously? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for configurable SSH host key algorithms to improve compatibility with modern SSH clients like Visual Studio 2022 that no longer support RSA host keys.
Changes
HostKeyAlgorithmfield toagentssh.Config- allows configuration of SSH host key algorithm--ssh-host-key-algorithm- with environment variableCODER_AGENT_SSH_HOST_KEY_ALGORITHMCoderSignerfunction - now accepts algorithm parameter and supports both key typesTesting
Usage
Resolves
This addresses the Visual Studio 2022 compatibility issue where newer SSH clients reject RSA host keys, allowing users to configure Ed25519 which is widely supported and more secure.