Skip to content

feat: basic implementation of secrets feature [DO NOT MERGE] #18775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
88d5eec
feat: basic implementation of secrets feature
evgeniy-scherbina Jul 7, 2025
8fdc61b
test: fix migration tests
evgeniy-scherbina Jul 8, 2025
c6249d3
test: fix rbac tests
evgeniy-scherbina Jul 8, 2025
17326fd
Merge remote-tracking branch 'origin/main' into yevhenii/secrets-prot…
evgeniy-scherbina Jul 8, 2025
b5c904a
feat: add get-user-secret db query
evgeniy-scherbina Jul 8, 2025
122387f
feat: add list-user-secrets db query
evgeniy-scherbina Jul 8, 2025
147b22d
test: fix CI and dbmem
evgeniy-scherbina Jul 8, 2025
dc046ae
temporary commit
evgeniy-scherbina Jul 14, 2025
78bfa24
feat: implement API for creating & listing secrets
evgeniy-scherbina Jul 14, 2025
e416afe
Merge remote-tracking branch 'origin/main' into yevhenii/secrets-prot…
evgeniy-scherbina Jul 14, 2025
887f914
fix: delete dbmem after merge
evgeniy-scherbina Jul 14, 2025
991db6d
Merge remote-tracking branch 'origin/main' into yevhenii/secrets-prot…
evgeniy-scherbina Jul 15, 2025
6db3754
fix: migration numbers
evgeniy-scherbina Jul 15, 2025
f0c3a5e
ci: fix doc tests
evgeniy-scherbina Jul 15, 2025
137fb71
ci: fix doc tests
evgeniy-scherbina Jul 15, 2025
b580b5d
test: add TestUserSecrets test
evgeniy-scherbina Jul 15, 2025
b40ec25
test: improve TestUserSecrets test
evgeniy-scherbina Jul 15, 2025
ac8b0b6
refactor: add comments
evgeniy-scherbina Jul 15, 2025
b8712a6
feat: implement create command
evgeniy-scherbina Jul 16, 2025
1a716d2
feat: implement list command
evgeniy-scherbina Jul 16, 2025
e739809
feat: implement get command
evgeniy-scherbina Jul 16, 2025
e288818
feat: implement get --with-value command
evgeniy-scherbina Jul 16, 2025
dd2883e
make gen/golden-files
evgeniy-scherbina Jul 16, 2025
91b16de
ci: fix ci
evgeniy-scherbina Jul 17, 2025
39b0e41
feat: add params for auto-injection
evgeniy-scherbina Jul 21, 2025
a3d167e
feat: update creation of manifest
evgeniy-scherbina Jul 23, 2025
a73a4c5
fix: run make gen/golden-files
evgeniy-scherbina Jul 23, 2025
a1ee752
fix: run make gen
evgeniy-scherbina Jul 23, 2025
27de2ce
feat: pass secrets to agent via Manifest
evgeniy-scherbina Jul 23, 2025
57044e3
fix: merge with master
evgeniy-scherbina Jul 23, 2025
c281c5e
tmp commit
evgeniy-scherbina Jul 24, 2025
1a9a9d5
temporary workaround to pass tests
evgeniy-scherbina Jul 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions agent/agent.go
Original file line number Diff line number Diff line change
Expand Up @@ -1410,6 +1410,10 @@ func (a *agent) updateCommandEnv(current []string) (updated []string, err error)
}
envs["PATH"] = fmt.Sprintf("%s%c%s", a.scriptRunner.ScriptBinDir(), filepath.ListSeparator, envs["PATH"])

for _, secret := range manifest.UserSecrets {
envs[secret.EnvName] = secret.Value
}

for k, v := range envs {
updated = append(updated, fmt.Sprintf("%s=%s", k, v))
}
Expand Down
Loading
Loading