-
Notifications
You must be signed in to change notification settings - Fork 952
chore: modify parameter dynamic immutability behavior #18583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b12a492
to
7e4ef44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dynamic parameter immutability so that a parameter’s mutability is determined solely by its current state rather than its prior state.
- Adds a Terraform test scenario for dynamic immutability in
testdata
. - Introduces two new integration tests (
PreviouslyImmutable
,PreviouslyMutable
) and a unit test (BecameImmutable
) to capture dynamic behavior. - Refactors
ResolveParameters
to drop the oldoriginalValues
map and usepreviousValuesMap
directly when validating immutability.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
enterprise/coderd/testdata/parameters/dynamicimmutable/main.tf | Adds Terraform snippet for dynamic immutability testing. |
enterprise/coderd/dynamicparameters_test.go | Adds integration tests covering parameters that flip mutability. |
coderd/dynamicparameters/resolver_test.go | Adds a unit test for a parameter transitioning from mutable to immutable. |
coderd/dynamicparameters/resolver.go | Removes the originalValues cache and uses previousValuesMap for immutability checks. |
aslilac
approved these changes
Jul 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter
mutablity
is determined by the current state. So a previouslyimmutable
parameter can becomemutable
.Terraform:
Trivial Case:
isimmutable = true
&immutable = "bar"
immutable = foo
Immutability source from the past
isimmutable = true
&immutable = "bar"
immutable = foo
&isimmutable = false
mutable = true
Why ignore the previous parameter state?
Ignoring previous state is vastly simplier and more intuitive. If the previous parameter
mutability
affected the current build, then questions such as, "What if the last build failed? Do we take the last successful build?", etc.