fix: Use verified and primary email for GitHub signup #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing a panic due to nil pointer dereference. It required all users signing up had a public email, which is an unreasonable requirement!
coadler
approved these changes
Apr 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #1230 +/- ##
==========================================
+ Coverage 65.63% 65.66% +0.02%
==========================================
Files 269 269
Lines 17337 17378 +41
Branches 162 164 +2
==========================================
+ Hits 11379 11411 +32
- Misses 4768 4776 +8
- Partials 1190 1191 +1
Continue to review full report at Codecov.
|
f0ssel
approved these changes
Apr 29, 2022
|
I think we'll need a better answer to how we do the email verification in general before launch, so we'll grab some customer feedback. |
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
This was causing a panic due to nil pointer dereference. It required all users signing up had a public email, which is an unreasonable requirement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing a panic due to nil pointer dereference.
It required all users signing up had a public email,
which is an unreasonable requirement!