Skip to content

fix: Update initial window size on SSH TTY #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: Update initial window size on SSH TTY #1174

merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

It required a window resize before to trigger
a size update. This fixes it!

It required a window resize before to trigger
a size update. This fixes it!
@kylecarbs kylecarbs requested a review from coadler April 25, 2022 22:54
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) April 25, 2022 22:56
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1174 (340ddfb) into main (947e8f9) will decrease coverage by 0.23%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #1174      +/-   ##
==========================================
- Coverage   66.51%   66.28%   -0.24%     
==========================================
  Files         263      259       -4     
  Lines       16573    16377     -196     
  Branches      156      156              
==========================================
- Hits        11024    10855     -169     
+ Misses       4419     4402      -17     
+ Partials     1130     1120      -10     
Flag Coverage Δ
unittest-go-macos-latest 53.76% <25.00%> (-0.01%) ⬇️
unittest-go-postgres- 65.59% <25.00%> (-0.21%) ⬇️
unittest-go-ubuntu-latest 56.33% <25.00%> (+0.02%) ⬆️
unittest-go-windows-2022 ?
unittest-js 67.45% <ø> (ø)
Impacted Files Coverage Δ
agent/agent.go 64.62% <25.00%> (-3.88%) ⬇️
cli/configssh.go 61.19% <0.00%> (-6.72%) ⬇️
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
pty/ptytest/ptytest.go 86.95% <0.00%> (-4.35%) ⬇️
coderd/workspaceagents.go 58.92% <0.00%> (-4.29%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
coderd/turnconn/turnconn.go 81.91% <0.00%> (-3.20%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 947e8f9...340ddfb. Read the comment docs.

@kylecarbs kylecarbs merged commit 29d5588 into main Apr 25, 2022
@kylecarbs kylecarbs deleted the initialsize branch April 25, 2022 23:02
kylecarbs added a commit that referenced this pull request Jun 10, 2022
It required a window resize before to trigger
a size update. This fixes it!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants