feat: add View Source button for template administrators in workspace creation #18951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blink-so[bot]](https://avatars.githubusercontent.com/in/1271127?s=60&v=4){kind=small}
… creation Adds a View Source button to the workspace creation page that allows template administrators to quickly navigate to the template editor. The button: - Only appears for users with template update permissions - Links directly to the template version editor - Uses the ExternalLinkIcon for consistency with other source viewing features - Is positioned next to the Cancel button in the page header This addresses user friction where template admins expect to be able to edit templates directly from the workspace creation flow. Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
This comment was marked as spam.
This comment was marked as spam.
Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
aslilac
requested changes
Jul 21, 2025
Adds two new stories to test the View Source button functionality: - WithViewSourceButton: Shows the button for template administrators - WithoutViewSourceButton: Hides the button for regular users These stories exercise the canUpdateTemplate prop and demonstrate the conditional rendering of the View Source button. Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
aslilac
reviewed
Jul 23, 2025
Comment on lines
70
to
76
| canUpdateTemplate: { | ||
| object: { | ||
| resource_type: "template", | ||
| resource_id: templateQuery.data?.id ?? "", | ||
| }, | ||
| action: "update", | ||
| }, |
There was a problem hiding this comment.
you should just add this inside of the createWorkspaceChecks helper, that's what it is for
Comment on lines
406
to
424
| export const WithoutViewSourceButton: Story = { | ||
| args: { | ||
| canUpdateTemplate: false, | ||
| versionId: "template-version-123", | ||
| template: { | ||
| ...MockTemplate, | ||
| organization_name: "default", | ||
| name: "docker-template", | ||
| }, | ||
| }, | ||
| parameters: { | ||
| docs: { | ||
| description: { | ||
| story: | ||
| "This story shows the workspace creation page for users without template update permissions. The View Source button is hidden for these users.", | ||
| }, | ||
| }, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
you don't need a story for this. the default is false so every other story already verifies this.
| <Button size="sm" variant="outline" onClick={onCancel}> | ||
| Cancel | ||
| </Button> | ||
| <Stack direction="row" spacing={2}> |
There was a problem hiding this comment.
the actions prop is already rendered inside of a flex container that adds spacing. just use a fragment.
blink-so
bot
force-pushed
the
feat/view-source-button-workspace-creation
branch
from
4c1cdad to
96f849c
Compare
…ermissions Addresses review feedback: - Added View Source button to CreateWorkspacePageViewExperimental component - Refactored createWorkspaceChecks helper to include template update permission - Updated both regular and experimental pages to use the new permissions helper - Added story for experimental component with View Source button - Removed unnecessary WithoutViewSourceButton story (default behavior) The View Source button now appears in both the regular and experimental workspace creation pages for template administrators. Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
blink-so
bot
force-pushed
the
feat/view-source-button-workspace-creation
branch
from
96f849c to
aca0211
Compare
aslilac
approved these changes
Jul 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "View Source" button to the workspace creation page that allows template administrators to quickly navigate to the template editor.
Context: https://codercom.slack.com/archives/C015YDF37AT/p1753109218026359
Changes
canUpdateTemplatepermission check to workspace creation flowExternalLinkIconfor consistency with other source viewing featuresProblem Solved
Addresses user friction where template administrators expect to be able to edit templates directly from the workspace creation flow. Previously, admins had to navigate away from the workspace creation page to find the template editor.
Testing
Screenshots
The View Source button appears in the top-right corner of the workspace creation page, similar to the implementation shown in the original request.
Fixes user feedback about template admin workflow friction.