We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent cb92b79 commit 86d19b8Copy full SHA for 86d19b8
site/src/components/Filter/Filter.tsx
@@ -62,6 +62,16 @@ export const useFilter = ({
62
return;
63
}
64
65
+ /**
66
+ * @todo 2025-07-15 - We have a slightly nasty bug here, where trying to
67
+ * update state the "React way" causes our code to break.
68
+ *
69
+ * In theory, it would be better to make a copy of the search params. We
70
+ * can then mutate and dispatch the copy instead of the original. Doing
71
+ * that causes other parts of our existing logic to break, though.
72
+ * That's a sign that our other code is slightly broken, and only just
73
+ * happens to work by chance right now.
74
+ */
75
searchParams.set(useFilterParamsKey, serialized);
76
onSearchParamsChange(searchParams);
77
onUpdate?.(serialized);
0 commit comments