fix: update Filter logic to account for fallback filter

Parkreiner · Parkreiner · commit cb92b79abe31 · 2025-07-16T03:23:38.000Z
diff --git a/site/src/components/Filter/Filter.tsx b/site/src/components/Filter/Filter.tsx
@@ -57,14 +57,13 @@ export const useFilter = ({
 	const update = (newValues: string | FilterValues) => {
 		const serialized =
 			typeof newValues === "string" ? newValues : stringifyFilter(newValues);
-		const noUpdateNeeded = searchParams.get(useFilterParamsKey) === serialized;
+		const noUpdateNeeded = query === serialized;
 		if (noUpdateNeeded) {
 			return;
 		}
 
-		const copy = new URLSearchParams(searchParams);
-		copy.set(useFilterParamsKey, serialized);
-		onSearchParamsChange(copy);
+		searchParams.set(useFilterParamsKey, serialized);
+		onSearchParamsChange(searchParams);
 		onUpdate?.(serialized);
 	};
 
diff --git a/site/src/pages/AuditPage/AuditPage.test.tsx b/site/src/pages/AuditPage/AuditPage.test.tsx
@@ -15,6 +15,7 @@ import {
 import { server } from "testHelpers/server";
 import * as CreateDayString from "utils/createDayString";
 import AuditPage from "./AuditPage";
+import type { AuditLogsRequest } from "api/typesGenerated";
 
 interface RenderPageOptions {
 	filter?: string;
@@ -106,7 +107,7 @@ describe("AuditPage", () => {
 			await userEvent.type(filterField, query);
 
 			await waitFor(() =>
-				expect(getAuditLogsSpy).toBeCalledWith({
+				expect(getAuditLogsSpy).toHaveBeenCalledWith<[AuditLogsRequest]>({
 					limit: DEFAULT_RECORDS_PER_PAGE,
 					offset: 0,
 					q: query,
