fix: get workspace tests passing

Parkreiner · Parkreiner · commit 330d91db0ec5 · 2025-07-16T04:07:38.000Z
diff --git a/site/src/hooks/usePagination.ts b/site/src/hooks/usePagination.ts
@@ -19,8 +19,8 @@ export function usePagination(
 ): UsePaginationResult {
 	const { searchParams, onSearchParamsChange } = options;
 	const limit = DEFAULT_RECORDS_PER_PAGE;
-	const rawPage = Number.parseInt(searchParams.get(paginationKey) || "0", 10);
-	const page = Number.isNaN(rawPage) ? 1 : rawPage;
+	const rawPage = Number.parseInt(searchParams.get(paginationKey) || "1", 10);
+	const page = Number.isNaN(rawPage) || rawPage <= 0 ? 1 : rawPage;
 
 	return {
 		page,
diff --git a/site/src/pages/WorkspacesPage/WorkspacesPage.test.tsx b/site/src/pages/WorkspacesPage/WorkspacesPage.test.tsx
@@ -1,7 +1,7 @@
 import { screen, waitFor, within } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import { API } from "api/api";
-import type { Workspace } from "api/typesGenerated";
+import type { Template, WorkspacesResponse, Workspace } from "api/typesGenerated";
 import { http, HttpResponse } from "msw";
 import {
 	MockDormantOutdatedWorkspace,
@@ -28,18 +28,14 @@ describe("WorkspacesPage", () => {
 	});
 
 	it("renders an empty workspaces page", async () => {
-		// Given
 		server.use(
 			http.get("/api/v2/workspaces", async () => {
-				return HttpResponse.json({ workspaces: [], count: 0 });
+				return HttpResponse.json<WorkspacesResponse>({ workspaces: [], count: 0 });
 			}),
 		);
 
-		// When
 		renderWithAuth(<WorkspacesPage />);
-
-		// Then
-		await screen.findByText("Create a workspace");
+		await screen.findByRole("heading", { name: /Create a workspace/ });
 	});
 
 	it("renders a filled workspaces page", async () => {
