Skip to content

Make all treeview items expanded. Disable toggle. #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 8, 2023
Merged

Make all treeview items expanded. Disable toggle. #520

merged 2 commits into from
Sep 8, 2023

Conversation

lihebi
Copy link
Collaborator

@lihebi lihebi commented Sep 8, 2023

This PR makes the TreeView controlled. All items are expanded, and toggle is disabled.

Some TODOs:

  • the expand/toggle info should be persisted to DB so that it remains after refreshing. This should be kept at UserRepoData, not in the Yjs, because users should have their own views.
  • ba50b0d implemented toggle on icon, not label. This is the expected behavior, but needs to be enabled after we save the toggle status to DB/UserRepoData.

This PR also fixes a console error:

Screenshot 2023-09-07 at 6 44 11 PM

@lihebi lihebi merged commit a7cc37d into codepod-io:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lihebi