Skip to content

properly update activeRuntime #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2023
Merged

properly update activeRuntime #499

merged 1 commit into from
Aug 31, 2023

Conversation

lihebi
Copy link
Collaborator

@lihebi lihebi commented Aug 31, 2023

Now the active runtime should be set automatically when spawn/kill a runtime.

  1. if a runtime is deleted, and if it was the active runtime, set the active runtime to undefined
  2. if a runtime is added, and there's no active runtime, set the active runtime to the first runtime

#495 also tried to fix it.

@lihebi lihebi merged commit 2ee67ab into codepod-io:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lihebi