feat: add native-rendered Electron app #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually, this PR is a general platform to build approach 1 as well. I'm merging this. |
lihebi
changed the title
lihebi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two ways to make the electron app:
[Approach 1, server-based, preferred]: Host UI at
localhost:3000and API servers atlocalhost:4000, and use Electron window as a browser. This approach makes it possible to open the app in the browser, so that[Approach 2, native-rendered]: Let host only API server on
localhost:4000, and render the UI pages & components directly in Electron API. This is the regular way of using Electron.This PR implements approach 2. It can now render the page without a problem. However, approach 1 should be the way to go.
Therefore, this PR is only for reference.